Fix new terminology by abnegate · Pull Request #95 · utopia-php/migration

abnegate · 2025-07-23T01:50:42Z

Summary by CodeRabbit

Refactor
- Removed legacy resource types from database resource grouping.
- Standardized naming by replacing "relatedTable" with "relatedCollection".
- Updated index export to use real index IDs and length details.
- Enhanced resource reporting to handle additional resource types with improved counting.

coderabbitai · 2025-07-23T01:50:48Z

Walkthrough

The changes remove legacy resource types from a constant array in the Transfer class, update conditional checks to handle the legacy document type alongside row types, rename an internal option key in the Relationship class constructor, refine the construction of Relationship and Index objects in the Appwrite source to use more accurate metadata, and prefix PHP built-in functions with a global namespace qualifier in the API class report method.

Changes

File	Change Summary
src/Migration/Transfer.php	Removed legacy resource types from `GROUP_DATABASES_RESOURCES` constant; updated conditional checks to include `Resource::TYPE_DOCUMENT` alongside `Resource::TYPE_ROW`.
src/Migration/Resources/Database/Columns/Relationship.php	Changed constructor to store related entity key as `'relatedCollection'` instead of `'relatedTable'`.
src/Migration/Sources/Appwrite.php	Modified `exportColumns` to use `relatedTable` if present, else `relatedCollection`; updated `exportIndexes` to use actual index IDs and lengths from source data.
src/Migration/Sources/Appwrite/Reader/API.php	Prefixed PHP built-in functions `array_merge`, `count`, and `in_array` with backslash in `report` method.

Estimated code review effort

2 (~20 minutes)

Possibly related PRs

Fix index construct #94: Also modifies the exportIndexes method in src/Migration/Sources/Appwrite.php by changing index construction parameters, indicating a direct code-level connection.

Poem

🐇 Hopping through code with a twitch of my nose,
Legacy types trimmed, and clarity grows.
Collections renamed, indexes set right,
Functions now called with a namespace bright.
A rabbit’s delight, in code freshly spun—
Leap forward we do, the cleanup is done! 🌿

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abb1c92 and 65399a1.

📒 Files selected for processing (2)

src/Migration/Resources/Database/Columns/Relationship.php (1 hunks)
src/Migration/Sources/Appwrite.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/Migration/Sources/Appwrite.php
src/Migration/Resources/Database/Columns/Relationship.php

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

abnegate · 2025-07-23T06:57:52Z

-
-        // legacy
-        Resource::TYPE_DOCUMENT,
-        Resource::TYPE_ATTRIBUTE,
-        Resource::TYPE_COLLECTION,


Having these here just duplicates what were store in the migrations resources, we now the have fallbacks to handle existing migrations that reference these

Remove legacy type from DB group

bdd4b9f

abnegate added 4 commits July 23, 2025 14:43

Fix index create

4c5423c

Add missing fallbacks

7c00ac4

Add missing fallbacks

98c9972

Fix relationships

cf1e3c5

abnegate changed the title ~~Remove legacy type from DB group~~ Fix new terminology Jul 23, 2025

ItzNotABug reviewed Jul 23, 2025

View reviewed changes

Comment thread src/Migration/Sources/Appwrite/Reader/API.php Outdated

abnegate commented Jul 23, 2025

View reviewed changes

Remove redundant double check

f7c948a

fogelito reviewed Jul 23, 2025

View reviewed changes

Comment thread src/Migration/Sources/Appwrite.php

fogelito reviewed Jul 23, 2025

View reviewed changes

Comment thread src/Migration/Sources/Appwrite.php Outdated

fogelito approved these changes Jul 23, 2025

View reviewed changes

abnegate added 2 commits July 23, 2025 19:26

Fallbacks

abb1c92

Fix relationships

65399a1

abnegate merged commit cf6b192 into main Jul 23, 2025
4 checks passed

abnegate deleted the fix-groups branch July 23, 2025 08:02

coderabbitai Bot mentioned this pull request Oct 11, 2025

documents db + vector db migration #114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix new terminology#95

Fix new terminology#95
abnegate merged 8 commits into
mainfrom
fix-groups

abnegate commented Jul 23, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

abnegate Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

abnegate commented Jul 23, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

abnegate Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abnegate commented Jul 23, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)